Add missing stream keyword argument to dpnp.ndarray.to_device method#2263
Merged
antonwolfy merged 7 commits intomasterfrom Jan 17, 2025
Merged
Add missing stream keyword argument to dpnp.ndarray.to_device method#2263antonwolfy merged 7 commits intomasterfrom
stream keyword argument to dpnp.ndarray.to_device method#2263antonwolfy merged 7 commits intomasterfrom
Conversation
antonwolfy
requested review from
AlexanderKalistratov,
vlad-perevezentsev and
vtavana
as code owners
Collaborator
Collaborator
AlexanderKalistratov
left a comment
AlexanderKalistratov
left a comment
There was a problem hiding this comment.
Everything is good, but we are not testing actual functionality of stream keyword which purpose is to do synchronization.
We need to figure out how to properly test it.
Contributor
|
Array API standard conformance tests for dpnp=0.17.0dev4=py312he4f9c94_12 ran successfully. |
Contributor
Author
|
@AlexanderKalistratov , I've applied the comments, please rereview. |
vlad-perevezentsev
approved these changes
Jan 17, 2025
Contributor
vlad-perevezentsev
left a comment
vlad-perevezentsev
left a comment
There was a problem hiding this comment.
LGTM!
Thank you @antonwolfy
github-actions bot
added a commit
that referenced
this pull request
Jan 17, 2025
…hod (#2263) The PR proposes to align `dpnp.ndarray.to_device` method with python array API and to add support of `stream` keyword argument. The tests coverage is extended to cover new argument. Previously muted array-api test is enabled back. Note, tests for `dpnp.__dlpack__` are updated due to recent changes done in [dpctl#1969](IntelPython/dpctl#1969). 6cc2348
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PR proposes to align
dpnp.ndarray.to_devicemethod with python array API and to add support ofstreamkeyword argument.The tests coverage is extended to cover new argument. Previously muted array-api test is enabled back.
Note, tests for
dpnp.__dlpack__are updated due to recent changes done in dpctl#1969.